[PATCH] D43962: [GlobalISel][utils] Adding the init version of Instruction Select Testgen

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin updated this revision to Diff 144043.
rtereshin marked 16 inline comments as done.
rtereshin added a comment.

Hi Daniel @dsanders,

Thank you for looking into this and the detailed review.

> It would be helpful to move things like the indentation correction on testImm*(), the introduction of buildTable and getMatchTable(), the changes to coverage, moving the emission of selectImpl() down, etc. into a separate patch(es).

I believe I have this done, please take a look at the extracted patches:
https://reviews.llvm.org/D46095
https://reviews.llvm.org/D46096
https://reviews.llvm.org/D46097
https://reviews.llvm.org/D46098

I'm also half-through the inline comments.


Repository:
  rL LLVM

https://reviews.llvm.org/D43962

Files:
  include/llvm/CodeGen/GlobalISel/InstructionSelectTestgen.h
  include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
  include/llvm/CodeGen/GlobalISel/InstructionSelectorTestgen.h
  include/llvm/InitializePasses.h
  lib/CodeGen/GlobalISel/CMakeLists.txt
  lib/CodeGen/GlobalISel/GlobalISel.cpp
  lib/CodeGen/GlobalISel/InstructionSelectTestgen.cpp
  lib/CodeGen/GlobalISel/InstructionSelectorTestgen.cpp
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/GlobalISelEmitter.cpp
  utils/update_instruction_select_testgen_tests.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43962.144043.patch
Type: text/x-patch
Size: 62115 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180426/b238da7d/attachment.bin>