[PATCH] D44184: Write DWARF data into WASM object file

[Yury Delendik via Phabricator via llvm-commits]

yurydelendik marked 2 inline comments as done.
yurydelendik added inline comments.


================
Comment at: include/llvm/Object/RelocVisitor.h:339
+        HasError = false;
+        return 0;
+      }
----------------
sbc100 wrote:
> Presumably we should be returning something useful here?
> 
> Looks like COFF and Mach-O just "return Value" and don't see "HasError" in the success case.
Whatever passed as Value to RelocVisitor as SymInfo address (https://github.com/llvm-mirror/llvm/blob/0c191c5e264b8cab92b7fe720a1173f54cd4c9b2/lib/DebugInfo/DWARF/DWARFContext.cpp#L1430) is not suitable for DWARFContext


Repository:
  rL LLVM

https://reviews.llvm.org/D44184