[PATCH] D46082: [LowerTypeTests] Mark .cfi.jumptable nounwind.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 25 14:14:39 PDT 2018
efriedma created this revision.
efriedma added reviewers: pcc, eugenis.
Herald added a reviewer: javed.absar.
Herald added a subscriber: chrib.
It doesn't unwind, and the wrong marking leads to the creation of an .eh_frame section when it isn't necessary.
Repository:
rL LLVM
https://reviews.llvm.org/D46082
Files:
lib/Transforms/IPO/LowerTypeTests.cpp
test/Transforms/LowerTypeTests/function-arm-thumb.ll
test/Transforms/LowerTypeTests/function.ll
Index: test/Transforms/LowerTypeTests/function.ll
===================================================================
--- test/Transforms/LowerTypeTests/function.ll
+++ test/Transforms/LowerTypeTests/function.ll
@@ -49,7 +49,7 @@
}
; X86-LINUX: define private void @[[JT]]() #[[ATTR:.*]] section ".text.cfi" align 8 {
-; X86-WIN32: define private void @[[JT]]() section ".text.cfi" align 8 {
+; X86-WIN32: define private void @[[JT]]() #[[ATTR:.*]] section ".text.cfi" align 8 {
; ARM: define private void @[[JT]]() #[[ATTR:.*]] section ".text.cfi" align 4 {
; THUMB: define private void @[[JT]]() #[[ATTR:.*]] section ".text.cfi" align 4 {
@@ -70,9 +70,10 @@
; NATIVE-SAME: "s,s"(void ()* @f.cfi, void ()* @g.cfi)
-; X86-LINUX: attributes #[[ATTR]] = { {{.*}}naked
-; ARM: attributes #[[ATTR]] = { {{.*}}naked
-; THUMB: attributes #[[ATTR]] = { {{.*}}naked{{.*}}"target-cpu"="cortex-a8"
+; X86-LINUX: attributes #[[ATTR]] = { naked nounwind }
+; X86-WIN32: attributes #[[ATTR]] = { nounwind }
+; ARM: attributes #[[ATTR]] = { naked nounwind
+; THUMB: attributes #[[ATTR]] = { naked nounwind "target-cpu"="cortex-a8" "target-features"="+thumb-mode" }
; WASM32: ![[I0]] = !{i64 1}
; WASM32: ![[I1]] = !{i64 2}
Index: test/Transforms/LowerTypeTests/function-arm-thumb.ll
===================================================================
--- test/Transforms/LowerTypeTests/function-arm-thumb.ll
+++ test/Transforms/LowerTypeTests/function-arm-thumb.ll
@@ -37,5 +37,5 @@
; CHECK-NEXT: unreachable
; CHECK-NEXT: }
-; CHECK-DAG: attributes #[[AA]] = { naked "target-features"="-thumb-mode" }
-; CHECK-DAG: attributes #[[AT]] = { naked "target-cpu"="cortex-a8" "target-features"="+thumb-mode" }
+; CHECK-DAG: attributes #[[AA]] = { naked nounwind "target-features"="-thumb-mode" }
+; CHECK-DAG: attributes #[[AT]] = { naked nounwind "target-cpu"="cortex-a8" "target-features"="+thumb-mode" }
Index: lib/Transforms/IPO/LowerTypeTests.cpp
===================================================================
--- lib/Transforms/IPO/LowerTypeTests.cpp
+++ lib/Transforms/IPO/LowerTypeTests.cpp
@@ -1290,6 +1290,8 @@
// by Clang for -march=armv7.
F->addFnAttr("target-cpu", "cortex-a8");
}
+ // Make sure we don't emit .eh_frame for this function.
+ F->addFnAttr(Attribute::NoUnwind);
BasicBlock *BB = BasicBlock::Create(M.getContext(), "entry", F);
IRBuilder<> IRB(BB);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46082.144001.patch
Type: text/x-patch
Size: 2413 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180425/64ab1397/attachment.bin>
More information about the llvm-commits
mailing list