[PATCH] D46010: [AArch64] Improve cost of vector division by constant

Adhemerval Zanella via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 11:31:12 PDT 2018


zatrazz added a comment.

In https://reviews.llvm.org/D46010#1077903, @rengolin wrote:

> Do we have similar cost tests for x86, Arm and others? It would be nice to make sure the change to `BasicTTIImplBase` didn't break other targets' costs.


I should not change other architectures than AArch64 because 'isArithmeticDivFast' is a new method (only used by this patch). I initially added this logic on AArch64TargetTransformInfo.cpp, but since the division by constant is a platform agnostic transformation I though it would make sense to check the same check on a platform agnostic manner.


Repository:
  rL LLVM

https://reviews.llvm.org/D46010





More information about the llvm-commits mailing list