[PATCH] D46072: [DagCombine][InstCombine][NFC] De Morgan law tests

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 10:42:32 PDT 2018


lebedev.ri created this revision.
lebedev.ri added reviewers: spatel, craig.topper, RKSimon, arphaman, MatzeB, thegameg.
lebedev.ri added a dependent revision: D46073: [DagCombine] De Morgan laws:  'nand' logic with an inverted operand.

As discussed in https://reviews.llvm.org/D46031, it seems DAGCombine should simplify using De Morgan laws.

`test/CodeGen/MIR/Generic/demorgan.ll` is a 100% carbon copy of `test/Transforms/InstCombine/demorgan.ll`.
`test/Transforms/InstCombine/demorgan-extra.ll` and `test/CodeGen/MIR/Generic/demorgan-extra.ll` are new and also 100% carbon copy

I think for DAGCombine we should be testing MIR output.
I *think* `test/CodeGen/MIR/Generic/` is the correct location given we stop after `machine-combiner` pass?


Repository:
  rL LLVM

https://reviews.llvm.org/D46072

Files:
  test/CodeGen/MIR/Generic/demorgan-extra.ll
  test/CodeGen/MIR/Generic/demorgan.ll
  test/Transforms/InstCombine/demorgan-extra.ll
  test/Transforms/InstCombine/demorgan.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46072.143960.patch
Type: text/x-patch
Size: 54518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180425/2cf5d026/attachment.bin>


More information about the llvm-commits mailing list