[PATCH] D36569: [globalisel][tablegen] Add support for fpimm and import of APInt/APFloat based ImmLeaf.

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: test/TableGen/GlobalISelEmitter.td:770
+// CHECK-NEXT:    GIR_Copy, /*NewInsnID*/0, /*OldInsnID*/0, /*OpIdx*/0, // dst
+// CHECK-NEXT:    GIR_CopyFConstantAsFPImm, /*NewInsnID*/0, /*OldInsnID*/0, // imm
+// CHECK-NEXT:    GIR_EraseFromParent, /*InsnID*/0,
----------------
dsanders wrote:
> tstellar wrote:
> > Is there a reason why  GIR_CopyFConstantAsFPImm was not implemented in InstructionSelector?
> The most likely explanation is that there were other issues with importing any of the rules that would have made use of it at the time. Do you have a test case that's hitting this?
Yes, D45994 hits this.  I created D45990 to try to implement GIR_CopyFConstantAsFPImm.  The main problem is that the AMDGPUGenGlobalISel.inc won't build, because this enum value is not defined.  The pattern that this was generated for, we don't need and won't ever use, so it's not a problem if this remains unimplemented, we just need to be able to build  AMDGPUGenGlobalISel.inc .


https://reviews.llvm.org/D36569