[PATCH] D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: test/ELF/mips-non-zero-gp0.s:10
+# as -mips32 -o test.o && ld.bfd -m elf32btsmip -r test.o
+# as -mips64 -o test.o && ld.bfd -m elf64btsmip -r test.o
+
----------------
I would not use `test.o` as there is no such file in your test case.

I suggest to explicitly list all 3 invocations here: for `mips-gp0-non-zero.o`, for `mips-n64-gp0-non-zero.o` and for `mips-micro-gp0-non-zero.o`. With that it is trivial to reproduce and people unfamiliar with mips like me do not need to guess where to use `-mips32/elf32btsmip` and where `-mips64/elf64btsmip` if they would want to rebuild the inputs.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45972