[PATCH] D45806: DAGcombiner: Handle correctly non-splat power of 2 -1 divisor

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 25 07:03:34 PDT 2018


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2949
+              DAG.getSplatBuildVector(
+                  VT, DL, DAG.getAllOnesConstant(DL, VT.getScalarType())),
+              ISD::SETEQ),
----------------
Do you need the getSplatBuildVector? I think DAG.getAllOnesConstant can accept a vector type:
```
DAG.getAllOnesConstant(DL, VT)
```


Repository:
  rL LLVM

https://reviews.llvm.org/D45806





More information about the llvm-commits mailing list