[PATCH] D45972: [ELF][MIPS] Fix calculation of GP relative relocations in case of relocatable output

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

It seems you can produce .o files you have added (mips-micro-gp0-non-zero.o, mips-n64-gp0-non-zero.o) with use of llvm-mc, right?
Can you do that in this patch? I think we generally want to avoid binaries in inputs. You might be able to test produced input objects to check they contain
non-zero gp0 if you think that makes sense.

(Would also probably be nice to do that for mips-gp0-non-zero.o in a followup).



================
Comment at: test/ELF/mips-non-zero-gp0.s:26
+
+# Source code for mips-micro-gp0-non-zero.o:
+
----------------
The source code is missing.


================
Comment at: test/ELF/mips-non-zero-gp0.s:42
+
+# REQUIRES: mips
+
----------------
Please move it to the first line of the test.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45972