[PATCH] D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax

[Javed Absar via Phabricator via llvm-commits]

javed.absar added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8729
+
+bool ScalarEvolution::isKnownPredicateWithoutInductionHelper(
+    ICmpInst::Predicate Pred, const SCEV *LHS, const SCEV *RHS) {
----------------
skatkov wrote:
> javed.absar wrote:
> > Hi Serguei. 
> > 
> > I tried to trace the split and code duplication, and I think it would probably be simpler to combine  'isKnownPredicateWithoutInduction' and 'isKnownPredicateWithoutInductionHelper' into just one function (if that's possible).
> Are you ok that we will have a code duplication in isKnownPredicateWithoutInduction and isKnownPredicate?
Yes I think that would be better for readability.


https://reviews.llvm.org/D46046