[PATCH] D45862: [InstCombine] Remove decanonicalizing transforms of selects

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 24 21:04:14 PDT 2018


mkazantsev updated this revision to Diff 143859.
mkazantsev retitled this revision from "[InstCombine] Relax restriction in foldSelectInstWithICmp for sake of smaller code size" to "[InstCombine] Remove decanonicalizing transforms of selects".
mkazantsev edited the summary of this revision.
mkazantsev added a comment.
Herald added a reviewer: javed.absar.
Herald added a subscriber: kristof.beyls.

Let's try an alternative approach. In this patch we remove harmful transforms that replace selects with random pieces of bit magic.

Here we only stop harmful transforms. The patch that will canonicalize all this bit magic to selects will go separately.


https://reviews.llvm.org/D45862

Files:
  lib/Transforms/InstCombine/InstCombineSelect.cpp
  test/Transforms/InstCombine/rem.ll
  test/Transforms/InstCombine/select-icmp-and.ll
  test/Transforms/InstCombine/three-way-comparison.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45862.143859.patch
Type: text/x-patch
Size: 34190 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180425/d58326b3/attachment.bin>


More information about the llvm-commits mailing list