[PATCH] D45994: AMDGPU/GlobalISel: Enable TableGen'd instruction selector

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 2 inline comments as done.
tstellar added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:440
     break;
+  case TargetOpcode::G_OR:
+    return selectImpl(I, CoverageInfo);
----------------
arsenm wrote:
> Should the default be selectImpl?
Eventually yes, but enabling it for everything now could lead to crashes and miscompiles that will prevent the SelectionDAG fallback from activating.  I would like to get a full piglit run working with GISel for simple shaders and SelectionDAG for everything else before we make selectImpl() the default.


Repository:
  rL LLVM

https://reviews.llvm.org/D45994