[PATCH] D46029: [llvm-objcopy] Implement --redefine-sym option

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:392
+        InputArgs.getLastArgValue(OBJCOPY_redefine_symbol).split('=');
+    if (Config.Old2New.first.empty() || Config.Old2New.second.empty())
+      error("Bad format for --redefine-sym");
----------------
jakehehrlich wrote:
> Why is it a problem to have an empty symbol name? I don't think the spec says anything against that.
you are right, 
empty names are allowed, 
i've played with binutils objcopy a bit more and it looks like it will produce an error message only  if the option's value doesn't contain '=' at all, i'll update the check to match this behavior


Repository:
  rL LLVM

https://reviews.llvm.org/D46029