[PATCH] D46021: [DEBUGINFO] Disable emission of the dwarf sections, but allow directives.

Tue Apr 24 10:17:02 PDT 2018

There is no support for no ', debug' in this patch, I'm going to implement it in the next patch, NVPTX specific. This one is a generic.
-------------
Best regards,
Alexey Bataev

24.04.2018 13:11, David Blaikie пишет:

On Tue, Apr 24, 2018 at 10:08 AM Alexey Bataev via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
ABataev added a comment.

In https://reviews.llvm.org/D46021#1077023<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD46021%231077023&data=02%7C01%7C%7C9f1f4b4c119146a32ac108d5aa06689f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636601866850650990&sdata=w7spmo1u8yJbBS6DD2H%2BUrgRoxqVC9eQ8x20sQEHP4A%3D&reserved=0>, @dblaikie wrote:

> Sorry, I'm a bit confused.
>
> 1. I'd expect /this/ behavior (line table directives, but no debug_info, etc) to be controlled via a DICompileUnit emission kind (a value between "NoDebug" and "LineTablesOnly" as Paul mentioned).
> 2. I'd expect the "no ', debug'" flag (which I don't see in this change? Is it missing? is it elsewhere?) to be controlled via an MCOption - because it must be global.
>
>   Now, arguably, if we have the global "no ', debug'" flag we maybe might as well use it to implement this behavior too since we don't have any other use for it? So maybe (2) invalidates (1).

I thought, that it is not very useful to have an option that, actually, controls only single target and I decided instead to add the option that just disables emission of the DWARF sections. In this case we don't need the special debug info mode, we can use this option.

I'm not sure I follow - specifically I'm still not sure where the "no ', debug'" support is in this patch - did I miss it?

As for whether it's useful to have the "don't emit debug sections except for the line table" as a DICompileUnit feature - the reason to put it there would be for consistency with other related variations in debug info emission, even if it is only used by one target.

Repository:
  rL LLVM

https://reviews.llvm.org/D46021<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD46021&data=02%7C01%7C%7C9f1f4b4c119146a32ac108d5aa06689f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636601866850650990&sdata=4dmAKbJQOcfYKnRKFL7qpae5jB%2BNhNwfuXIFs7CoI2o%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180424/f261368d/attachment.html>