[PATCH] D46020: [lit, lldbsuite] Update the lldbsuite to correctly run tests on windows and windows server

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: lit/Suite/lldbtest.py:47
+        # of the command.
+        cmd = [sys.executable] + self.dotest_cmd + [testPath, '-p', testFile]
 
----------------
labath wrote:
> Do we need to worry about picking the correct `python`/`python_d` for release vs. debug builds?
If it's a debug build, `sys.executable` should already be `python_d.exe`.  So this should be correct.

My question though, is where does `self.dotest_cmd` come from?  Would it ever be the case that this already has the python executable?  Then you'd have an error because it would be specified twice.  


Repository:
  rL LLVM

https://reviews.llvm.org/D46020