[llvm] r330720 - [X86] Remove unnecessary FMA reg-mem InstRW scheduler overrides.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 24 07:47:11 PDT 2018


Author: rksimon
Date: Tue Apr 24 07:47:11 2018
New Revision: 330720

URL: http://llvm.org/viewvc/llvm-project?rev=330720&view=rev
Log:
[X86] Remove unnecessary FMA reg-mem InstRW scheduler overrides.

Modified:
    llvm/trunk/lib/Target/X86/X86SchedBroadwell.td
    llvm/trunk/lib/Target/X86/X86SchedHaswell.td
    llvm/trunk/lib/Target/X86/X86SchedSkylakeClient.td
    llvm/trunk/lib/Target/X86/X86SchedSkylakeServer.td
    llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s
    llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s

Modified: llvm/trunk/lib/Target/X86/X86SchedBroadwell.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SchedBroadwell.td?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SchedBroadwell.td (original)
+++ llvm/trunk/lib/Target/X86/X86SchedBroadwell.td Tue Apr 24 07:47:11 2018
@@ -1547,15 +1547,6 @@ def BWWriteResGroup115 : SchedWriteRes<[
 }
 def: InstRW<[BWWriteResGroup115], (instregex "(V?)PCMPGTQrm")>;
 
-def BWWriteResGroup116 : SchedWriteRes<[BWPort01,BWPort23]> {
-  let Latency = 10;
-  let NumMicroOps = 2;
-  let ResourceCycles = [1,1];
-}
-def: InstRW<[BWWriteResGroup116],
-            (instregex "VF(N)?M(ADD|SUB|ADDSUB|SUBADD)(132|213|231)P(D|S)m",
-                       "VF(N)?M(ADD|SUB)(132|213|231)S(D|S)m")>;
-
 def BWWriteResGroup117 : SchedWriteRes<[BWPort1,BWPort23]> {
   let Latency = 10;
   let NumMicroOps = 3;

Modified: llvm/trunk/lib/Target/X86/X86SchedHaswell.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SchedHaswell.td?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SchedHaswell.td (original)
+++ llvm/trunk/lib/Target/X86/X86SchedHaswell.td Tue Apr 24 07:47:11 2018
@@ -1946,8 +1946,7 @@ def HWWriteResGroup92_2 : SchedWriteRes<
   let ResourceCycles = [1,1];
 }
 def: InstRW<[HWWriteResGroup92_2], (instregex "(V?)MULSDrm",
-                                              "(V?)MULSSrm",
-                                              "VF(N)?M(ADD|SUB)(132|213|231)S(D|S)m")>;
+                                              "(V?)MULSSrm")>;
 
 def HWWriteResGroup93 : SchedWriteRes<[HWPort1,HWPort5]> {
   let Latency = 5;

Modified: llvm/trunk/lib/Target/X86/X86SchedSkylakeClient.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SchedSkylakeClient.td?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SchedSkylakeClient.td (original)
+++ llvm/trunk/lib/Target/X86/X86SchedSkylakeClient.td Tue Apr 24 07:47:11 2018
@@ -1758,8 +1758,6 @@ def: InstRW<[SKLWriteResGroup122], (inst
                                               "(V?)MULSSrm",
                                               "(V?)SUBSDrm",
                                               "(V?)SUBSSrm")>;
-def: InstRW<[SKLWriteResGroup122],
-            (instregex "VF(N)?M(ADD|SUB)(132|213|231)S(D|S)m")>;
 
 def SKLWriteResGroup123 : SchedWriteRes<[SKLPort23,SKLPort01]> {
   let Latency = 9;

Modified: llvm/trunk/lib/Target/X86/X86SchedSkylakeServer.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SchedSkylakeServer.td?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SchedSkylakeServer.td (original)
+++ llvm/trunk/lib/Target/X86/X86SchedSkylakeServer.td Tue Apr 24 07:47:11 2018
@@ -3615,8 +3615,6 @@ def SKXWriteResGroup137 : SchedWriteRes<
   let NumMicroOps = 2;
   let ResourceCycles = [1,1];
 }
-def: InstRW<[SKXWriteResGroup137],
-            (instregex "VF(N)?M(ADD|SUB)(132|213|231)S(D|S)m")>;
 def: InstRW<[SKXWriteResGroup137], (instregex "ADDSDrm",
                                               "ADDSSrm",
                                               "CMPSDrm",

Modified: llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-1.s Tue Apr 24 07:47:11 2018
@@ -12,8 +12,8 @@ vfmadd213ps (%rdi), %xmm1, %xmm2
 # HASWELL:      [0,0]	DeeeER    .    ..	vaddps	%xmm0, %xmm0, %xmm1
 # HASWELL-NEXT: [0,1]	D===eeeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
 
-# BDWELL:       [0,0]	DeeeER    .    .	vaddps	%xmm0, %xmm0, %xmm1
-# BDWELL-NEXT:  [0,1]	D===eeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
+# BDWELL:       [0,0]	DeeeER    . .	vaddps	%xmm0, %xmm0, %xmm1
+# BDWELL-NEXT:  [0,1]	DeeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
 
 # SKYLAKE:      [0,0]	DeeeeER   .    ..	vaddps	%xmm0, %xmm0, %xmm1
 # SKYLAKE-NEXT: [0,1]	D====eeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2

Modified: llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s?rev=330720&r1=330719&r2=330720&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s (original)
+++ llvm/trunk/test/tools/llvm-mca/X86/fma3-read-after-ld-2.s Tue Apr 24 07:47:11 2018
@@ -12,8 +12,8 @@ vfmadd213ps (%rdi), %xmm1, %xmm2
 # HASWELL:      [0,0]	DeeeER    .    ..	vaddps	%xmm0, %xmm0, %xmm2
 # HASWELL-NEXT: [0,1]	D===eeeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
 
-# BDWELL:       [0,0]	DeeeER    .    .	vaddps	%xmm0, %xmm0, %xmm2
-# BDWELL-NEXT:  [0,1]	D===eeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
+# BDWELL:       [0,0]	DeeeER    . .	vaddps	%xmm0, %xmm0, %xmm2
+# BDWELL-NEXT:  [0,1]	DeeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2
 
 # SKYLAKE:      [0,0]	DeeeeER   .    ..	vaddps	%xmm0, %xmm0, %xmm2
 # SKYLAKE-NEXT: [0,1]	D====eeeeeeeeeeER	vfmadd213ps	(%rdi), %xmm1, %xmm2




More information about the llvm-commits mailing list