[PATCH] D45572: [X86] Replace action Promote with Custom for operation ISD::SINT_TO_FP

Vyacheslav via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 24 07:43:26 PDT 2018


vrybalov added a comment.

Simon, thank you for the test patching. I did not check it with recent patches. In the future I will be more careful with it.



================
Comment at: llvm/trunk/test/CodeGen/X86/sitofp.ll:17
+  %conv = zext i16 %a to i32
+  %conv1 = sitofp i32 %conv to double
+  ret double %conv1
----------------
lebedev.ri wrote:
> It would be really nice for all the tests to be committed first,
> so that the following codechange commit actually shows the test change.
It was impossible to commit the test before the patch.  LLC hung on the test and did not produce any output.


Repository:
  rL LLVM

https://reviews.llvm.org/D45572





More information about the llvm-commits mailing list