[PATCH] D45952: [AArch64][SVE] Asm: Support for gather LD1/LDFF1 (scalar + vector (32bit elts, unscaled)) load instructions.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 24 02:17:27 PDT 2018


sdesmalen added a comment.

In https://reviews.llvm.org/D45952#1076019, @rengolin wrote:

> These patches all look very similar, I think they could be all in the same commit? Even being large, may be easier to see how they are similar and do a quick review.


Hi Renato, they could indeed be in a single commit but I thought it would be easier to review by distinguish them as separate patches based on their addressing modes, e.g.

  scalar + vector (32bit elts, unscaled)
    vs e.g.
  scalar + vector (64bit elts, scaled)

I'd be happy to squash them into a single commit and upload a new patch, but would it for this series be sufficient to use the one-liner below and do a 'svn diff' to see how they compare?

  for patch in $(seq 45952 45957); do
    arc patch D${patch};
  done


https://reviews.llvm.org/D45952





More information about the llvm-commits mailing list