[PATCH] D45880: [AArch64][SVE] Enable DiagnosticPredicates for SVE LD1 instructions.

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:527
     int64_t Val = MCE->getValue();
     return Val >= MinVal && Val <= MaxVal && (Val % Scale) == 0;
   }
----------------
I think this would be more explicit on how it returns math/no-match instead of converting a boolean to an enum.

this would prevent future changes of the enum class and implicit assumptions. same down there.


https://reviews.llvm.org/D45880