[PATCH] D45982: [TTI, AArch64] Add transpose shuffle kind
Javed Absar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 23 14:28:09 PDT 2018
javed.absar added inline comments.
================
Comment at: include/llvm/Analysis/TargetTransformInfo.h:642
enum ShuffleKind {
- SK_Broadcast, ///< Broadcast element 0 to all other elements.
- SK_Reverse, ///< Reverse the order of the vector.
- SK_Alternate, ///< Choose alternate elements from vector.
- SK_InsertSubvector, ///< InsertSubvector. Index indicates start offset.
- SK_ExtractSubvector,///< ExtractSubvector Index indicates start offset.
- SK_PermuteTwoSrc, ///< Merge elements from two source vectors into one
- ///< with any shuffle mask.
- SK_PermuteSingleSrc ///< Shuffle elements of single source vector with any
- ///< shuffle mask.
+ SK_Broadcast, ///< Broadcast element 0 to all other elements.
+ SK_Reverse, ///< Reverse the order of the vector.
----------------
Not sure why indentation change is needed
================
Comment at: lib/Analysis/TargetTransformInfo.cpp:707
+ // matrix is stored in two result vectors such that one vector contains
+ // elements from all the even-numbered rows and the other vector contains
+ // elements from all the odd-numbered rows. For example, a 2x4 matrix can be
----------------
would it be more accurate to say '..such that one vector contains _interleaved_ elements from all the even numbered rows ..."
================
Comment at: lib/Analysis/TargetTransformInfo.cpp:737
+
+ // 4. The difference between consecutive even-numbered elements must be equal
+ // to two.
----------------
Test 4 and 5 could be perhaps combined into one loop?
Repository:
rL LLVM
https://reviews.llvm.org/D45982
More information about the llvm-commits
mailing list