[PATCH] D45817: [PostRASink] extend the live-in check for all aliased registers

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.
Herald added a reviewer: javed.absar.

Hi,

LGTM with small nits.

Cheers,
Quentin



================
Comment at: lib/CodeGen/MachineSink.cpp:987
 getSingleLiveInSuccBB(MachineBasicBlock &CurBB,
-                      ArrayRef<MachineBasicBlock *> SinkableBBs, unsigned Reg,
-                      const TargetRegisterInfo *TRI) {
+                      SmallPtrSetImpl<MachineBasicBlock *> &SinkableBBs,
+                      unsigned Reg, const TargetRegisterInfo *TRI) {
----------------
This should be const, right?


================
Comment at: lib/CodeGen/MachineSink.cpp:1013
 static MachineBasicBlock *getSingleLiveInSuccBB(
-    MachineBasicBlock &CurBB, ArrayRef<MachineBasicBlock *> SinkableBBs,
+    MachineBasicBlock &CurBB, SmallPtrSetImpl<MachineBasicBlock *> &SinkableBBs,
     ArrayRef<unsigned> DefedRegsInCopy, const TargetRegisterInfo *TRI) {
----------------
Ditto


https://reviews.llvm.org/D45817