[PATCH] D45968: StackSlotColoring: Decide colors per stack ID

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

Disclaimer: I haven't never looked at how this pass actually works so take my comments with a grain of salt!

Hi Matt,

If we do the tracking per StackID, how do we make sure the UsedColors don't overlaps between conflicting StackIDs?

Basically, I am not saying the patch is wrong, instead I am looking at what kind of assert/verify we could add to make sure it doesn't happen going down the path of the data not being "globally sync-ed".

Cheers,
-Quentin


https://reviews.llvm.org/D45968