[PATCH] D45938: Improves x86 interrupt error message on argument type error
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 23 09:49:56 PDT 2018
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:2994
if (CallConv == CallingConv::X86_INTR) {
- bool isLegal = Ins.size() == 1 ||
- (Ins.size() == 2 && ((Is64Bit && Ins[1].VT == MVT::i64) ||
- (!Is64Bit && Ins[1].VT == MVT::i32)));
- if (!isLegal)
+ bool isArgnLegal = Ins.size() == 1 || Ins.size() == 2;
+ if (!isArgnLegal)
----------------
Since you're touching this code anyway, do you mind capitalizing the new variable names to match coding standards.
https://reviews.llvm.org/D45938
More information about the llvm-commits
mailing list