[PATCH] D45951: [AArch64][SVE] Asm: Add AsmOperand classes for SVE gather/scatter addressing modes.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:861
   template <int ElementWidth, unsigned Class>
-  bool isSVEVectorRegOfWidth() const {
+  DiagnosticPredicate isSVEVectorRegOfWidth() const {
     return isSVEVectorReg<Class>() &&
----------------
fhahn wrote:
> I think this won't compile unless D45879 is committed. I do not think we should block this patch series on D45879.
Hi Florian, well spotted. The DiagnosticPredicate should indeed not be used in this patch, I must have missed this!
I'll remove this change and update patch D45958 accordingly (this is patch [8/8], the negative tests).
When (or if) D45879 makes it in, I will post another patch that improves the diagnostics for all the negative tests added in D45958.


https://reviews.llvm.org/D45951