[PATCH] D44782: Account for partial stack slot spills (PR30821)

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb requested changes to this revision.
andreadb added a comment.
This revision now requires changes to proceed.

Hi Jeremy.

I was going to commit this patch for you. However, there are two problems with the test case.

First of all, the test should not be an LLI test. Ideally, you would want a MIR test (see this document: https://llvm.org/docs/MIRLangRef.html) to only test the changes introduced by the stack slot coloring pass. You can start with a simple mir test obtained from `llc -stop-before=stack-slot-coloring`.

Second: your test clearly requires an x86 target. So, you should have had a `REQUIRES: x86-registered-target` line in your test.
That being said, I think the LLI test should be replaced with a MIR test.


https://reviews.llvm.org/D44782