[PATCH] D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 22 19:15:49 PDT 2018


hsaito added a comment.

In https://reviews.llvm.org/D45420#1074648, @rengolin wrote:

> > So, at the moment, what we need to settle are 1) file names to use and 2) move to Analysis or keep it under Transform.
>
> We should keep inside Transform for now, until we have non-Transform code using it.
>
> I agree not splitting LoopUtils is probably the simplest way forward. I don't like it as well, but I'd like to avoid code motion that can move again once we have a clear view, making it hard to git bisect changes (especially in a time of VPlan potentially breaking the world. :)


OK. I'll let Legal change land on Transform and postpone the split of LoopUtils. As a result, this patch will be abandoned. FYI, next thing I'll be working on is LoopVectorizationCostModel ---- to make it work on VPlan.


Repository:
  rL LLVM

https://reviews.llvm.org/D45420





More information about the llvm-commits mailing list