[PATCH] D45864: [RISCV] Support .option rvc and norvc

[Sameer AbuAsal via Phabricator via llvm-commits]

sabuasal added inline comments.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1000
+
+  if (IDVal == ".option") {
+    return parseDirectiveOption();
----------------
no braces needed.


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1012
+  // At the moment only identifiers are supported.
+  if (Tok.isNot(AsmToken::Identifier)) {
+    return Error(Parser.getTok().getLoc(),
----------------
no braces needed


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1023
+    Parser.Lex();
+    if (Parser.getTok().isNot(AsmToken::EndOfStatement)) {
+      return Error(Parser.getTok().getLoc(),
----------------
no braces needed


================
Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1035
+    Parser.Lex();
+    if (Parser.getTok().isNot(AsmToken::EndOfStatement)) {
+      return Error(Parser.getTok().getLoc(),
----------------
no braces needed


Repository:
  rL LLVM

https://reviews.llvm.org/D45864