[PATCH] D41979: [bcanalyzer] Recognize more stream types
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 21 09:51:00 PDT 2018
modocache updated this revision to Diff 143457.
modocache edited the summary of this revision.
modocache added a comment.
Sorry for letting this diff languish for so long. I updated the tests to be simple files with just the bytes necessary to be picked up as a specific stream type. I also moved the magic number reading over to a static helper function. I considered adding this function as a member of `llvm::BirstreamReader`, but chose not to for now, because doing so (as far as I can tell) would mean encoding Clang's magic numbers into LLVM's machinery. Let me know if you have different thoughts. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D41979
Files:
test/Bitcode/stream-types.c
test/Bitcode/stream-types.c.ast
test/Bitcode/stream-types.c.dia
tools/llvm-bcanalyzer/llvm-bcanalyzer.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41979.143457.patch
Type: text/x-patch
Size: 4056 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180421/5da401a2/attachment.bin>
More information about the llvm-commits
mailing list