[PATCH] D45918: [lit] Generate a single lit cfg file for tests that require dotest.py
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 21 01:27:22 PDT 2018
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
One inline question/suggestion but otherwise this LGTM. Thanks Stella!
================
Comment at: test/CMakeLists.txt:125
+# The framework path is passed to the test arguments as $<TARGET_FILE_DIR:liblldb>. This won't work in the
+# LLDB_DOTEST_ARGS when using a generator that supports multiple configurations such as Visual Studio,
----------------
Is there any disadvantage to moving this and the next set or arguments to the `LLDB_EXECUTABLE_PATH_ARGS_STR`?
================
Comment at: test/CMakeLists.txt:168
+# We need this to expand the generator expressions. TARGET_FILE_DIR is OK here because we want to
+# generate a coopy of lldb-dotest per configuration.
file(GENERATE
----------------
s/coopy/copy/
Repository:
rL LLVM
https://reviews.llvm.org/D45918
More information about the llvm-commits
mailing list