[PATCH] D45893: add more "anchors"

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

I'd say if we can't actually get it totally clean & enable the warning, maybe it's not worth doing all this? & you (& others in your situation) can contribute patches on an as-needed basis?

Though I don't mind too much having these committed.



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:160
+private:
+  virtual void anchor() {}
 };
----------------
This isn't an anchor, though, since it's defined in-line?


================
Comment at: include/llvm/MC/MCSubtargetInfo.h:178
+
+  virtual void anchor();
 };
----------------
Probably make this private as you've done in other cases.


================
Comment at: lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:547
+
+// void DWARFDebugFrame::anchor() {}
----------------
Take it this caused some link problems/layering violations?


Repository:
  rL LLVM

https://reviews.llvm.org/D45893