[PATCH] D45563: [X86][AArch64][NFC] Add tests for masked merge unfolding
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 20 11:50:44 PDT 2018
lebedev.ri added inline comments.
================
Comment at: test/CodeGen/AArch64/unfold-masked-merge-scalar.ll:454-457
+; CHECK-NEXT: .cfi_def_cfa_offset 32
+; CHECK-NEXT: .cfi_offset w30, -8
+; CHECK-NEXT: .cfi_offset w19, -16
+; CHECK-NEXT: .cfi_offset w20, -32
----------------
spatel wrote:
> lebedev.ri wrote:
> > spatel wrote:
> > > If you mark functions with 'nounwind', it should remove the cfi noise.
> > Does not work for aarch64, and i'd prefer to keep it consistent.
> By 'does not work', you mean the script wasn't working, right? Can you try again after:
> rL330453
>
> Hopefully, we can get rid of the cfi noise for both targets now.
>
> Note that there's little consistency between targets, but I appreciate that goal (the vast majority of AArch tests don't have auto-generated checks).
>
Thank you, that was it!
Repository:
rL LLVM
https://reviews.llvm.org/D45563
More information about the llvm-commits
mailing list