[PATCH] D45021: [WebAssembly] Distinguish debug/symbol names in the Wasm structs. NFC

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: include/llvm/BinaryFormat/Wasm.h:104
+  StringRef SymbolName; // from the "linking" section
+  StringRef DebugName; // from the "name" section
   uint32_t Comdat; // from the "comdat info" section
----------------
sbc100 wrote:
> What do you think about dropping DebugName completely here?  Since the name section is not really used in the object format right now this would make sense to me.  If you really want to get to the debug names we have a method on the object to get them right?
I've kept it, since we don't entirely ignore it. When reading in a relocatable Wasm file, we will propagate the DebugName if it's specified, which I think is a useful feature to keep hold of for now.


Repository:
  rL LLVM

https://reviews.llvm.org/D45021