[PATCH] D45333: WIP: [LIT] Have lit run the lldb test suite

Ted Woodward via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 20 08:25:22 PDT 2018


ted added a comment.

@JDevlieghere  I'm seeing the same issue as @alberto_magni . The Visual Studio cmake generator gives errors. We're reverting it internally, but it needs to be fixed or reverted ASAP.

The issue could be this set of code from test/CMakeLists.txt:

  configure_file(
    ${CMAKE_CURRENT_SOURCE_DIR}/../lit/Suite/lit.site.cfg.in
    ${CMAKE_CURRENT_BINARY_DIR}/../lit/Suite/lit.site.cfg
    )
  file(GENERATE
    OUTPUT
    ${CMAKE_CURRENT_BINARY_DIR}/../lit/Suite/lit.site.cfg
    INPUT
    ${CMAKE_CURRENT_BINARY_DIR}/../lit/Suite/lit.site.cfg
    )

The equivalent from clang/test/CMakeLists.txt is:

  configure_lit_site_cfg(
    ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
    ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py
    MAIN_CONFIG
    ${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
    )
  
  configure_lit_site_cfg(
    ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.site.cfg.py.in
    ${CMAKE_CURRENT_BINARY_DIR}/Unit/lit.site.cfg.py
    MAIN_CONFIG
    ${CMAKE_CURRENT_SOURCE_DIR}/Unit/lit.cfg.py
    )


Repository:
  rL LLVM

https://reviews.llvm.org/D45333





More information about the llvm-commits mailing list