[PATCH] D45861: AMDGPU/GlobalISel: Implement select() for 32-bit G_OR

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 23:59:33 PDT 2018


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

One nit, LGTM.



================
Comment at: lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:482
+    if (!RC->isAllocatable()) {
+      // constrainSelectedInstRegOperands() cannot handle non-allocatble register
+      // classes like VS_*, so we need to constrain those registers manually.
----------------
Typo: allocatable


Repository:
  rL LLVM

https://reviews.llvm.org/D45861





More information about the llvm-commits mailing list