[PATCH] D45849: [ELF] --warn-backrefs: use the same GroupId for object files in the same --{start, end}-lib

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 17:53:43 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/Driver.cpp:987
     case OPT_end_group:
-      if (!InputFile::IsInGroup)
+      if (!InputFile::IsInGroup || InLib)
         error("stray --end-group");
----------------
Do you need this? I think you now always set IsInGroup if you are InLib, so this new condition doesn't seem necessary.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45849





More information about the llvm-commits mailing list