[PATCH] D45851: [llvm-objcopy] Fix sh_link for more types of sections

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 17:24:50 PDT 2018


alexshap created this revision.
alexshap added reviewers: jakehehrlich, jhenderson.
alexshap created this object with visibility "All Users".
Herald added subscribers: kristof.beyls, javed.absar.

With this change I was able to build and link a large c/c++ project for android-arm,
previously the linker was crashing, that is an issue on its own, but the root cause is in llvm-objcopy.
The issue is that we should update sh_link for more types of sections (i.e. for SHT_ARM_EXIDX, SHT_HASH) 
(sh_info for these sections is 0).

Test plan: make check-all


Repository:
  rL LLVM

https://reviews.llvm.org/D45851

Files:
  test/tools/llvm-objcopy/armexidx-link.test
  test/tools/llvm-objcopy/dynsym-error-remove-strtab.test
  tools/llvm-objcopy/Object.cpp
  tools/llvm-objcopy/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45851.143199.patch
Type: text/x-patch
Size: 6444 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180420/13b3bf1b/attachment.bin>


More information about the llvm-commits mailing list