[PATCH] D45754: [PM/LoopUnswitch] Detect irreducible control flow within loops and skip unswitching non-trivial edges.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 11:43:06 PDT 2018


chandlerc added a comment.

In https://reviews.llvm.org/D45754#1072141, @fhahn wrote:

> Thanks, LGTM.
>
> Having a single function to detect irreducible CFGs allows us to test it more widely and in case it turns out to be a bottleneck, I think there are a couple of things we can do to improve the performance. The most prominent issue is probably that we re-do work for inner loops
>  , when loops  are processed from inner to outer loop nests.


Thanks for the review, and totally agree about the tradeoffs.


Repository:
  rL LLVM

https://reviews.llvm.org/D45754





More information about the llvm-commits mailing list