[PATCH] D45801: COFF: Use (name, output characteristics) as a key when grouping input sections into output sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 19 09:55:04 PDT 2018


ruiu added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1127-1129
+    for (OutputSection *Sec : OutputSections)
+      if (Sec->Name == Name)
+        Sec->setPermissions(Perm);
----------------
Does this mean that we now have multiple sections that have the same name? Is it OK?


https://reviews.llvm.org/D45801





More information about the llvm-commits mailing list