[PATCH] D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D45787#1071927, @gbedwell wrote:

> What's the more general plan for regression testing exegesis?  It looks like the issue with pfm failing to match counters was a regression introduced  by https://reviews.llvm.org/rL329675 due to the trailing commas. It would be nice to be able to have regression tests for this sort of thing, especially as it's under active development so the churn is likely to be quite high along with the risk of introducing regressions.  I know it gets complicated due to the libpfm dependency and the fact it's CPU specific, but it should still be a solvable problem.


I've raised PR37176 to track this - it took us the best part of a day to track down the trailing comma problem which was time that could have been saved if CI would have caught it for us.


Repository:
  rL LLVM

https://reviews.llvm.org/D45787