[PATCH] D45787: [llvm-exegesis] Fix PfmIssueCountersTable creation

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added a comment.
This revision is now accepted and ready to land.

> I'm a bit confused by the extra comma in the counter's name

This is actually fixed by this patch :) Thx!



================
Comment at: utils/TableGen/SubtargetEmitter.cpp:689
 }
 static bool EmitPfmIssueCountersTable(const CodeGenProcModel &ProcModel,
                                       raw_ostream &OS) {
----------------
Do you mind adding a line feed.


================
Comment at: utils/TableGen/SubtargetEmitter.cpp:719
+        OS << ",\" \"" << PfmCounters[p];
+      OS << "\",  // #" << i << " = ";
+      OS << CounterDef->getValueAsDef("Resource")->getName() << "\n";
----------------
Thx for adding the space after the comment :)


Repository:
  rL LLVM

https://reviews.llvm.org/D45787