[PATCH] D45778: [COFF] Mark images with no exception handlers for /safeseh

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/Writer.cpp:830
     PE->DLLCharacteristics |= IMAGE_DLL_CHARACTERISTICS_GUARD_CF;
-  if (Config->Machine == I386 && !SEHTable &&
-      !Symtab->findUnderscore("_load_config_used"))
+  if (Config->Machine == I386 && SetNoSEHCharacteristic)
     PE->DLLCharacteristics |= IMAGE_DLL_CHARACTERISTICS_NO_SEH;
----------------
ruiu wrote:
> Maybe you should move I386 to createSEHTable as well?
I found a way to do this that I like.


https://reviews.llvm.org/D45778