[PATCH] D45778: [COFF] Mark images with no exception handlers for /safeseh

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/Writer.cpp:833-834
+  // able to find the safe exception handler table.
+  if (Config->Machine == I386 && (!HasSafeExceptionHandlers ||
+                                  !Symtab->findUnderscore("_load_config_used")))
     PE->DLLCharacteristics |= IMAGE_DLL_CHARACTERISTICS_NO_SEH;
----------------
ruiu wrote:
> Maybe we should move these conditions to createSEHTable and make it a Config member (such as Config->SEH?)
That makes sense, but I wouldn't want to put mutable state on Config. We can just put it on Writer.


https://reviews.llvm.org/D45778