[PATCH] D42759: [CGP] Split large data structres to sink more GEPs

[Haicheng Wu via Phabricator via llvm-commits]

haicheng marked 2 inline comments as done.
haicheng added inline comments.


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4933
+          } else
+            NewBaseInsertPt = std::next(BaseI->getIterator());
+        } else {
----------------
efriedma wrote:
> I think you have to be a bit more careful here to avoid inserting a GEP into a block with a catchswitch.  (This is Windows-only exception-handling, so maybe difficult to trigger.)
Now I check if the blocks contain catchswitch when collecting GEPs.


Repository:
  rL LLVM

https://reviews.llvm.org/D42759