[PATCH] D45687: [AArch64][AsmParser] NFC: Cleanup parsing of scalar registers.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 18 01:45:20 PDT 2018
sdesmalen added a comment.
In https://reviews.llvm.org/D45687#1070654, @samparker wrote:
> This is a nice cleanup. LGTM with the one inline nit.
Thanks!
================
Comment at: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4537
StringRef Kind;
RegisterKind = RegKind::NeonVector;
+ ParseRes = tryParseVectorRegister(RegNum, Kind, RegKind::NeonVector);
----------------
samparker wrote:
> RegisterKind variable can be removed right? Same below too.
RegisterKind is still used for the pair that is inserted into RegisterReqs, so that it can be looked up for that register kind in matchRegisterNameAlias.
https://reviews.llvm.org/D45687
More information about the llvm-commits
mailing list