[PATCH] D45751: [X86] Don't crash on bad operand modifiers in inline assembly

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 17 22:20:02 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL330238: [X86] Don't crash on bad operand modifiers in inline assembly (authored by ctopper, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D45751?vs=142873&id=142883#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D45751

Files:
  llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
  llvm/trunk/test/CodeGen/X86/inline-asm-bad-modifier.ll


Index: llvm/trunk/test/CodeGen/X86/inline-asm-bad-modifier.ll
===================================================================
--- llvm/trunk/test/CodeGen/X86/inline-asm-bad-modifier.ll
+++ llvm/trunk/test/CodeGen/X86/inline-asm-bad-modifier.ll
@@ -0,0 +1,8 @@
+; RUN: not llc -mtriple=x86_64-- < %s 2>&1 | FileCheck %s
+
+;CHECK: error: invalid operand in inline asm: 'vmovd ${1:x}, $0'
+define i32 @foo() {
+entry:
+  %0 = tail call i32 asm sideeffect "vmovd ${1:x}, $0", "=r,x,~{dirflag},~{fpsr},~{flags}"(<2 x i64> <i64 240518168632, i64 240518168632>)
+  ret i32 %0
+}
Index: llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
===================================================================
--- llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
+++ llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
@@ -372,6 +372,12 @@
   unsigned Reg = MO.getReg();
   bool EmitPercent = true;
 
+  if (!X86::GR8RegClass.contains(Reg) &&
+      !X86::GR16RegClass.contains(Reg) &&
+      !X86::GR32RegClass.contains(Reg) &&
+      !X86::GR64RegClass.contains(Reg))
+    return true;
+
   switch (Mode) {
   default: return true;  // Unknown mode.
   case 'b': // Print QImode register


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45751.142883.patch
Type: text/x-patch
Size: 1163 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180418/e0bb0aef/attachment-0001.bin>


More information about the llvm-commits mailing list