[PATCH] D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree

[Hideki Saito via Phabricator via llvm-commits]

hsaito added a comment.

In https://reviews.llvm.org/D45420#1069721, @rengolin wrote:

> Adding Diego and Florian. We just had a good chat about this and maybe keeping the headers inside `Transform` for now would be better for the changes to come. We can move it later when it becomes clearer what the purpose is.
>
> We can also split `LoopUtils` while still inside `Transform` and then move to `Analysis` later when it makes sense.


Side effect of that is https://reviews.llvm.org/D45552 will have to land in Transform first and then move to Analysis when the descriptors move.

> what the purpose is.

For me, placing the code in the right location is one of the simplest things to avoid duplicate efforts and improve reusability. Having said that, our near-term reuse of Legal (https://reviews.llvm.org/D45552) change still works even if it lands in Transform. So, I won't insist like a purist. Then, I no longer have a good motivation to split the LoopUtil, but since I don't like to do the same thing twice, I might as well finish the splitting work.

So, at the moment, what we need to settle are 1) file names to use and 2) move to Analysis or keep it under Transform.

Thanks,
Hideki


Repository:
  rL LLVM

https://reviews.llvm.org/D45420