[PATCH] D45751: [X86] Don't crash on bad operand modifiers in inline assembly

[Craig Topper via Phabricator via llvm-commits]

craig.topper created this revision.
craig.topper added a reviewer: echristo.
Herald added a subscriber: eraman.

Previously if a modifer was placed on a non-GPR register class we would hit an assert or crash.


https://reviews.llvm.org/D45751

Files:
  lib/Target/X86/X86AsmPrinter.cpp
  test/CodeGen/X86/inline-asm-bad-modifier.ll


Index: test/CodeGen/X86/inline-asm-bad-modifier.ll
===================================================================
--- /dev/null
+++ test/CodeGen/X86/inline-asm-bad-modifier.ll
@@ -0,0 +1,8 @@
+; RUN: not llc -mtriple=x86_64-- < %s 2>&1 | FileCheck %s
+
+;CHECK: error: invalid operand in inline asm: 'vmovd ${1:x}, $0'
+define i32 @foo() {
+entry:
+  %0 = tail call i32 asm sideeffect "vmovd ${1:x}, $0", "=r,x,~{dirflag},~{fpsr},~{flags}"(<2 x i64> <i64 240518168632, i64 240518168632>)
+  ret i32 %0
+}
Index: lib/Target/X86/X86AsmPrinter.cpp
===================================================================
--- lib/Target/X86/X86AsmPrinter.cpp
+++ lib/Target/X86/X86AsmPrinter.cpp
@@ -372,6 +372,12 @@
   unsigned Reg = MO.getReg();
   bool EmitPercent = true;
 
+  if (!X86::GR8RegClass.contains(Reg) &&
+      !X86::GR16RegClass.contains(Reg) &&
+      !X86::GR32RegClass.contains(Reg) &&
+      !X86::GR64RegClass.contains(Reg))
+    return true;
+
   switch (Mode) {
   default: return true;  // Unknown mode.
   case 'b': // Print QImode register


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45751.142873.patch
Type: text/x-patch
Size: 1063 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180418/f2cc74d9/attachment.bin>