[PATCH] D45749: [XRay][compiler-rt] Add noop patch functions for unsupported arches.

[Keith via Phabricator via llvm-commits]

kpw created this revision.
kpw added reviewers: dberris, pelikan.
Herald added subscribers: Sanitizers, delcypher, javed.absar, nemanjai.

Typed event patching is implemented for x86-64, but functions must
be defined for other arches.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D45749

Files:
  lib/xray/xray_AArch64.cc
  lib/xray/xray_arm.cc
  lib/xray/xray_mips.cc
  lib/xray/xray_mips64.cc
  lib/xray/xray_powerpc64.cc


Index: lib/xray/xray_powerpc64.cc
===================================================================
--- lib/xray/xray_powerpc64.cc
+++ lib/xray/xray_powerpc64.cc
@@ -99,6 +99,12 @@
   return false;
 }
 
+bool patchTypedEvent(const bool Enable, const uint32_t FuncId,
+                     const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT {
+  // FIXME: Implement in powerpc64?
+  return false;
+}
+
 } // namespace __xray
 
 extern "C" void __xray_ArgLoggerEntry() XRAY_NEVER_INSTRUMENT {
Index: lib/xray/xray_mips64.cc
===================================================================
--- lib/xray/xray_mips64.cc
+++ lib/xray/xray_mips64.cc
@@ -166,6 +166,12 @@
   // FIXME: Implement in mips64?
   return false;
 }
+
+bool patchTypedEvent(const bool Enable, const uint32_t FuncId,
+                     const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT {
+  // FIXME: Implement in mips64?
+  return false;
+}
 } // namespace __xray
 
 extern "C" void __xray_ArgLoggerEntry() XRAY_NEVER_INSTRUMENT {
Index: lib/xray/xray_mips.cc
===================================================================
--- lib/xray/xray_mips.cc
+++ lib/xray/xray_mips.cc
@@ -158,6 +158,12 @@
   return false;
 }
 
+bool patchTypedEvent(const bool Enable, const uint32_t FuncId,
+                     const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT {
+  // FIXME: Implement in mips?
+  return false;
+}
+
 } // namespace __xray
 
 extern "C" void __xray_ArgLoggerEntry() XRAY_NEVER_INSTRUMENT {
Index: lib/xray/xray_arm.cc
===================================================================
--- lib/xray/xray_arm.cc
+++ lib/xray/xray_arm.cc
@@ -149,6 +149,12 @@
   return false;
 }
 
+bool patchTypedEvent(const bool Enable, const uint32_t FuncId,
+                     const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT {
+  // FIXME: Implement in arm?
+  return false;
+}
+
 // FIXME: Maybe implement this better?
 bool probeRequiredCPUFeatures() XRAY_NEVER_INSTRUMENT { return true; }
 
Index: lib/xray/xray_AArch64.cc
===================================================================
--- lib/xray/xray_AArch64.cc
+++ lib/xray/xray_AArch64.cc
@@ -112,6 +112,12 @@
   return false;
 }
 
+bool patchTypedEvent(const bool Enable, const uint32_t FuncId,
+                     const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT {
+  // FIXME: Implement in aarch64?
+  return false;
+}
+
 // FIXME: Maybe implement this better?
 bool probeRequiredCPUFeatures() XRAY_NEVER_INSTRUMENT { return true; }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45749.142861.patch
Type: text/x-patch
Size: 2479 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180417/d022c4bf/attachment.bin>