[PATCH] D45737: COFF: Merge .idata, .didat and .edata into .rdata by default.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/test/COFF/pdb-publics-import.test:39
     .rdata debug directory data chunks
-CHECK-NEXT:   SC[.rdata]  | mod = 1, 0002:0000, size = 28, data crc = 0, reloc crc = 0
+CHECK-NEXT:   SC[???]     | mod = 1, 0002:0000, size = 28, data crc = 0, reloc crc = 0
 CHECK-NEXT:                 IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_SCN_MEM_READ
----------------
pcc wrote:
> This is the only weird thing in the test updates.
> 
> @zturner I'm not sure if this is a pre-existing problem with our pdb emission?
Actually looks like it was an off-by-one error in llvm-pdbutil -- fix incoming


https://reviews.llvm.org/D45737