[PATCH] D35688: More extendable LaneBitmask
Krzysztof Parzyszek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 17 11:10:25 PDT 2018
kparzysz added inline comments.
================
Comment at: include/llvm/MC/LaneBitmask.h:149
+ static LaneBitmask getLane(unsigned Lane) {
+ Type T;
+ T[Lane / 32] = 1u << (Lane % 32);
----------------
craig.topper wrote:
> I think this leaves all the other entries in T as garbage. This could explain the error hameeza is getting.
>
> Try changing this to
>
> ```
> Type T = {};
> ```
Good catch.
Btw, feel free to reinstate yourself as a reviewer if you feel so inclined...
Repository:
rL LLVM
https://reviews.llvm.org/D35688
More information about the llvm-commits
mailing list